Skip to content

Add Python 3.14 support, remove Python 3.10 support, update Poetry to 2.4.1#332

Open
pmachapman wants to merge 8 commits into
mainfrom
python_3.14
Open

Add Python 3.14 support, remove Python 3.10 support, update Poetry to 2.4.1#332
pmachapman wants to merge 8 commits into
mainfrom
python_3.14

Conversation

@pmachapman

@pmachapman pmachapman commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Fixes #258.


This change is Reviewable

@pmachapman pmachapman requested review from Enkidu93 and ddaspit July 14, 2026 00:24

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit reviewed 14 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Enkidu93 and pmachapman).


pyproject.toml line 40 at r1 (raw file):

  "Topic :: Text Processing :: Linguistic",
]
requires-python = ">=3.11,<3.15"

Do we have to remove support for 3.10 to get something to work? It is still officially supported until October.


tests/tokenization/sentencepiece/test_sentence_piece_tokenizer.py line 24 at r1 (raw file):

    tokenizer = SentencePieceTokenizer(model_filename)
    tokens = list(tokenizer.tokenize("Other travelling salesmen live a life of luxury."))
    assert len(tokens) == 35

Why did this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Python 3.14 support

2 participants